Apply black + isort code formatting tools#58
Open
dbready wants to merge 1 commit intofossology:masterfrom
Open
Apply black + isort code formatting tools#58dbready wants to merge 1 commit intofossology:masterfrom
dbready wants to merge 1 commit intofossology:masterfrom
Conversation
Member
|
@dbready looks like flake8 does not like black https://github.com/fossology/Nirjas/runs/5800396412?check_suite_focus=true |
Author
|
Unfortunate. I had hoped it would be non-controversial, but having to adjust flake rules just to push it through is not a great feeling. Most of the failures look like a divergent style choice between the two. Maybe I will poke around with it a bit and see if I can find the middle ground. Which mostly seems like it was isort and a few extra line breaks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apologies for the huge delta, this resulted from running black and isort to standardize the code formatting.
Style is a personal thing, so I will leave it to the authors if they want to accept it or not.