Fix semantic-release workflow permissions and concurrency#155
Fix semantic-release workflow permissions and concurrency#155deveaud-m merged 2 commits intofossology:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR enhances the semantic-release workflow configuration to ensure proper permissions and prevent concurrent release operations. The changes address missing GitHub Actions permissions required for python-semantic-release to fully manage releases and improve the concurrency settings to prevent race conditions.
- Expanded workflow permissions to include
issuesandpull-requestswrite access - Restructured concurrency configuration with explicit group naming and
cancel-in-progress: falseto prevent overlapping releases - Minor code cleanup including comment removal and trailing whitespace fixes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi maintainers |
|
@abdollahShahid thanks for creating this PR and trying to improve the semantic release workflow. I activated the actions for this PR, the failed tests are not related to this change, it is fine to merge without the full functional testsuite. I added some minor nitpick suggestions to improve the comments, I am not a fan of emojis in code files, I hope that's fine for you to delete them. The PR will be ready to merge once the suggestions are accepted, but this won't fully fix issue #143. Could you please adapt the description to avoid closing the issue after the merge? |
|
Thanks for the review! I’ve removed the emojis from the workflow comments and updated the PR description so it no longer closes #143. Ready for merge. |
deveaud-m
left a comment
There was a problem hiding this comment.
Looks like I forgot to send the pending reviews...
|
@deveaud-m No worries at all — thanks for the confirmation. Ready to merge whenever convenient. |
|
@abdollahShahid sorry for the delay, I was on holidays. Please integrate the last change as suggested before I can merge. |
I just merged a fix for the failing tests. Could you please update your fork and insert the second suggestion? I'll re-run the workflow and continue working on new features and fixes. |
9112887 to
67c7db4
Compare
|
Hi @deveaud-m — sorry for the delay, I’ve been busy contributing to a core repository recently. I’ve now updated my fork, rebased onto the latest main, and applied the remaining suggestion (removed the redundant workflow comment). Thanks a lot for the review and guidance! Whenever you have time, could you kindly take a look at PR #157 as well? Thanks again! |
Summary
python-semantic-release(issues, pull-requests).Test plan
.github/workflows/semantic-release.ymlwas modifiedRelated to #143