feat(sncast): Add versioned accounts schema - #4548
Open
integraledelebesgue wants to merge 1 commit into
Open
Conversation
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 19, 2026 16:13
df091b9 to
3febf64
Compare
integraledelebesgue
changed the title
integraledelebesgue
marked this pull request as ready for review
August 20, 2026 15:24
integraledelebesgue
requested review from
MKowalski8,
ddoktorski and
franciszekjob
and removed request for
MKowalski8
August 20, 2026 15:24
ddoktorski
reviewed
Aug 21, 2026
| #[derive(Clone, Debug, Deserialize, Serialize)] | ||
| pub struct Account { | ||
| pub public_key: Felt, | ||
| pub address: Option<Felt>, |
Contributor
There was a problem hiding this comment.
Why address is Option? 🤔
Contributor
Author
There was a problem hiding this comment.
It leaked from the previous logic, where native cast accounts were mixed with starkli ones. I changed the domain model and both schemas to enforce the address
| impl VersionedAccountsFile { | ||
| pub fn decode(input: &[u8]) -> Result<Self, AccountsError> { | ||
| if input.iter().all(u8::is_ascii_whitespace) { | ||
| return Ok(Self::V1(v1::AccountsFile::default())); |
Contributor
There was a problem hiding this comment.
Why V1 for an empty file?
Contributor
Author
There was a problem hiding this comment.
It's a natural solution - V1 file can technically be empty, while the V2 contains at least a version
Contributor
There was a problem hiding this comment.
What if someone creates an empty file and wants to add an account there?
Contributor
Author
There was a problem hiding this comment.
It will be deserialized as V1. Any modifications (writes/removes) will happen via AccountRepository.mutate that converts the content to the latest schema version
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
2 times, most recently
from
August 25, 2026 10:15
8b5ac73 to
3ecaf12
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
2 times, most recently
from
August 26, 2026 10:50
f62a6eb to
adff940
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 27, 2026 10:23
d69ff65 to
d5d3943
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 27, 2026 11:01
d5d3943 to
3da4f05
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 27, 2026 17:11
3da4f05 to
be70592
Compare
ddoktorski
reviewed
Aug 28, 2026
| impl VersionedAccountsFile { | ||
| pub fn decode(input: &[u8]) -> Result<Self, AccountsError> { | ||
| if input.iter().all(u8::is_ascii_whitespace) { | ||
| return Ok(Self::V1(v1::AccountsFile::default())); |
Contributor
There was a problem hiding this comment.
What if someone creates an empty file and wants to add an account there?
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 28, 2026 15:04
be70592 to
3f8188a
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
August 28, 2026 15:14
3f8188a to
b194201
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
2 times, most recently
from
August 28, 2026 15:20
cbc82f8 to
db06d71
Compare
franciszekjob
approved these changes
Aug 28, 2026
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
3 times, most recently
from
August 28, 2026 17:16
0a63276 to
6e21e2d
Compare
ddoktorski
approved these changes
Aug 31, 2026
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
2 times, most recently
from
September 2, 2026 10:48
270b677 to
c4ee71c
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
September 2, 2026 14:02
c4ee71c to
baa5911
Compare
integraledelebesgue
force-pushed
the
feat/sncast-accounts-schema-v2
branch
from
September 3, 2026 19:06
baa5911 to
bea8623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced changes
This PR introduces a versioned schema of the accounts file:
private_keyandledger_pathfields becomes the legacyv1variant. Its behaviour remains exactly the same.signerfield, deserialized as a tagged enum, is the latestv2variant.Both variants converge to the common
AccountsRegistrystructure that holds the accounts' data expressed using domain models from #4547.Utility functions in
sncast::accounts::schema::migrationsallow upgradingv1tov2.Checklist
CHANGELOG.md