refactor(sncast) Extract account helpers as clean services - #4552
Open
integraledelebesgue wants to merge 1 commit into
Open
refactor(sncast) Extract account helpers as clean services#4552integraledelebesgue wants to merge 1 commit into
integraledelebesgue wants to merge 1 commit into
Conversation
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 19, 2026 16:13
a53d0b2 to
b8c98b6
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 19, 2026 16:20
b8c98b6 to
dd3838e
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 19, 2026 16:33
dd3838e to
0ca682d
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 19, 2026 16:46
0ca682d to
a502bee
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
5 times, most recently
from
August 20, 2026 13:54
a3f7fbc to
a187780
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 20, 2026 14:04
a187780 to
b118ae3
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 20, 2026 14:10
b118ae3 to
46c6df7
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
2 times, most recently
from
August 20, 2026 15:12
00b47c8 to
85f8b9e
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 20, 2026 15:22
85f8b9e to
bf6a4d1
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 20, 2026 15:58
bf6a4d1 to
75d9b4f
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 20, 2026 16:08
75d9b4f to
bdf31bc
Compare
integraledelebesgue
changed the title
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
2 times, most recently
from
August 25, 2026 10:36
2de93c9 to
c5e3076
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 25, 2026 10:55
c5e3076 to
90e3488
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 26, 2026 10:50
90e3488 to
21452cc
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 26, 2026 11:23
21452cc to
8b13df0
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
2 times, most recently
from
August 27, 2026 08:38
62dd5f3 to
365859d
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 27, 2026 10:23
365859d to
c5e3494
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 27, 2026 11:01
c5e3494 to
38f5919
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
2 times, most recently
from
August 27, 2026 17:11
58ebea8 to
d42c1e9
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 28, 2026 15:04
d42c1e9 to
c1add54
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 28, 2026 15:14
c1add54 to
1f8d300
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
from
August 28, 2026 15:16
1f8d300 to
ab00fa3
Compare
integraledelebesgue
force-pushed
the
refactor/sncast-account-services
branch
2 times, most recently
from
August 28, 2026 15:49
3f1dfa4 to
e70fdeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduced changes
This PR introduces:
AccountSelectorthat differentiates the account variants (named, devnet and legacy starkli) and owns each one's dataAccountDeploymentServicethat owns the logic related to account deployment (address computation, fee estimation, deployment itself)AccountServicethat builds runtime accounts based onAccountSelectorand wraps the dispatch logic between a transparent APIThose new structures are used in place of old, messy code.
Checklist
CHANGELOG.md