Skip to content

Change default domainname from "none" to ""#103

Merged
dgeo merged 1 commit intofreebsd:masterfrom
criecm:fix_domainname
Dec 13, 2025
Merged

Change default domainname from "none" to ""#103
dgeo merged 1 commit intofreebsd:masterfrom
criecm:fix_domainname

Conversation

@dgeo
Copy link
Copy Markdown
Contributor

@dgeo dgeo commented Dec 12, 2025

NIS domainname enables all nss NIS subsystem if not empty.

This change could affect you if you are using NIS and your NIS domainname is "none".

Otherwise, you may escape strange bugs where some program (here samba, or mountd) may take some (say ~30) seconds at jail startup or simply fail, waiting for a NIS server to reply
for domainname "none"…

should fix #96

@dgeo dgeo self-assigned this Dec 12, 2025
@dgeo dgeo added the bug Something isn't working label Dec 12, 2025
@dgeo dgeo added this to the next milestone Dec 12, 2025
NIS domainname enables all nss NIS subsystem if not empty.

This change could affect you if you are using NIS and your NIS
domainname is "none".

Otherwise, you may escape strange bugs where some program (here
samba, or mountd) may take some (say ~30) seconds at jail startup
or simply fail, waiting for a NIS server to reply
for domainname "none"…

should fix freebsd#96
@coveralls
Copy link
Copy Markdown

coveralls commented Dec 12, 2025

Pull Request Test Coverage Report for Build 20182912774

Details

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 7.681%

Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/ioc_json.py 0 4 0.0%
Totals Coverage Status
Change from base Build 20181195791: -0.002%
Covered Lines: 793
Relevant Lines: 7838

💛 - Coveralls

Copy link
Copy Markdown
Contributor

@arrowd arrowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@dgeo dgeo merged commit 29ef837 into freebsd:master Dec 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nis domainname should not be set by default

3 participants