freeipa-ldap/freeipa-ldaps deprecated should use freeipa-4#1005
Open
lessfoobar wants to merge 4 commits intofreeipa:masterfrom
Open
freeipa-ldap/freeipa-ldaps deprecated should use freeipa-4#1005lessfoobar wants to merge 4 commits intofreeipa:masterfrom
lessfoobar wants to merge 4 commits intofreeipa:masterfrom
Conversation
rjeffman
requested changes
Dec 23, 2022
Member
rjeffman
left a comment
rjeffman
left a comment
There was a problem hiding this comment.
Is this supported on any version of firewalld? The roles must be supported, for example on CentOS 7.
Also, NTP port should also be supported, so something like (untested) {{ "--add-service=net" if ipaserver_no_ntp | default("True") | bool else "" }} to cope with NTP port which is not covered by service firewall-4.
And please, add a proper commit message explaining why the change is needed and what the change is about.
Member
|
BTW, thank you for the PR. This is a great catch! |
Author
|
@rjeffman somebody have already merged your suggestion thus I've fixed the freeipa-4 for runtime and permanent. Could you please review once more. |
Signed-off-by: lessfoobar <lessfoobar@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://imgur.com/a/xEysZ9Y