Fix edge cases in steps.field_update when primaryKey and foreignKeys are renamed #1598
Open
fjuniorr wants to merge 7 commits intofrictionlessdata:mainfrom
Open
Fix edge cases in steps.field_update when primaryKey and foreignKeys are renamed #1598fjuniorr wants to merge 7 commits intofrictionlessdata:mainfrom
fjuniorr wants to merge 7 commits intofrictionlessdata:mainfrom
Conversation
…en primary keys exists
if self.name is not part of the primary key, it can't be dropped from the pk
Contributor
Author
|
I've added another test case that is currently failing that happens when the foreign key being updated has the same name of the referenced column: I still need some time to investigate and propose a fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two more edge cases when
steps.field_updateis updating either primary or foreign keys: