Skip to content

Use attributes#289

Merged
peterdesmet merged 7 commits intomainfrom
attributes
Mar 5, 2026
Merged

Use attributes#289
peterdesmet merged 7 commits intomainfrom
attributes

Conversation

@peterdesmet
Copy link
Member

Why attributes

We are changing to an attributes so it is easier to separate:

  • properties: things that are included in the datapackage.json list
  • attributes: things that the frictionless functions have added to pass objects from one function to the next

Data frames do the same: attributes(iris)

We still remove all attributes in write_package (write_resource), so that the invisibly returned package is as written to disk

Affected properties

  • package$directory to attr(package, "directory")
  • resource$read_from to attr(resource, "data_location")

We are changing to an attribute so it is easier to separate:

- properties: things that are included in the datapackage.json list
- attributes: things that the frictionless functions have added to pass objects from one function to the next

Data frames do the same: `attributes(iris)`

We still remove all attributes in write_package (write_resource), so that the invisibly returned package is as written to disk
@codecov
Copy link

codecov bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (97f91a2) to head (b887ac3).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #289   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          650       658    +8     
=========================================
+ Hits           650       658    +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peterdesmet peterdesmet added this to the 1.3.0 milestone Dec 12, 2025
@peterdesmet peterdesmet requested review from PietrH and removed request for sannegovaert February 20, 2026 15:01
@peterdesmet peterdesmet merged commit d6ac567 into main Mar 5, 2026
7 checks passed
@peterdesmet peterdesmet deleted the attributes branch March 5, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants