Virtualization/LXC: use utsname instead of container name#993
Open
mayasd wants to merge 2 commits intofusioninventory:developfrom
Open
Virtualization/LXC: use utsname instead of container name#993mayasd wants to merge 2 commits intofusioninventory:developfrom
mayasd wants to merge 2 commits intofusioninventory:developfrom
Conversation
g-bougard
reviewed
Feb 4, 2022
Contributor
g-bougard
left a comment
There was a problem hiding this comment.
Interesting feature, good job.
I only have one suggestion, check it and tell us what you think.
You'll probably have to fix test if you decide to follow it.
g-bougard
reviewed
Feb 4, 2022
g-bougard
added a commit
to glpi-project/glpi-agent
that referenced
this pull request
Feb 4, 2022
Co-authored-by: Guillaume Bougard <gbougard@teclib.com>
Author
|
Hi, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change responds to a problem with container name created in Proxmox.
In fact an ID is use in Promox to named LXC container.
For example:
With ID instead of hostname we are unable to know which server it is in GLPI.
Proxmox preserve utsname in containers configuration file so if you are ok I think we can used utsname parameter if it's exist instead of container name displayed in lxc-ls command.