Fallback for Android 10 bug: getType() returns null for tree URIs#6402
Open
abakum wants to merge 2 commits into
Open
Fallback for Android 10 bug: getType() returns null for tree URIs#6402abakum wants to merge 2 commits into
abakum wants to merge 2 commits into
Conversation
Added boundWindow variable to track the association between EGLSurface and ANativeWindow, along with surfaceNeedsRecreate() function that determines whether the surface needs to be recreated. The new ensureSurface() function consolidates surface creation and recreation logic in one place. On some Android versions and devices, onNativeWindowDestroyed is not delivered when the app goes to the background, causing the surface to remain bound to a destroyed window. Tracking the binding makes recovery robust regardless of which callbacks are triggered.
Member
|
This PR seems to have multiple bug fixes on it - please check what you have pushed to this branch and update accordingly. |
Author
|
Only 3 bugs — that's not a lot for a PR :) |
Member
|
When they are unrelated they belong on different PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6401
Tested on emulator with API28, API29, API37