Skip to content

reproducible dev-env and minor code improvements - #4

Open
HannesGitH wants to merge 3 commits into
gaspode-t-wonderdog:mainfrom
HannesGitH:main
Open

reproducible dev-env and minor code improvements#4
HannesGitH wants to merge 3 commits into
gaspode-t-wonderdog:mainfrom
HannesGitH:main

Conversation

@HannesGitH

@HannesGitH HannesGitH commented Feb 17, 2026

Copy link
Copy Markdown

Moin!


This PR introduces the following improvements:

  • added a nix flake to allow everyone generating the exact same stl by having the exact same version of openscad

  • did some minor code improvents to make

    • customizer more user-friendly
    • make parameters more readably, for easier code modification (more to come ;))

@HannesGitH HannesGitH mentioned this pull request Feb 18, 2026
@gretel

gretel commented Feb 19, 2026

Copy link
Copy Markdown

honestly i have no idea why nix should be used in this context. also don't see the benefit of the other changes mixed in here; a PR should address a single concern and not leave fiddly work to the maintainers.
just my five cents.

@HannesGitH

HannesGitH commented Feb 19, 2026

Copy link
Copy Markdown
Author

honestly i have no idea why nix should be used in this context

rn its only so that every developer here has the same openscad installed when entering the folder (direnv), no need to manage that, and if the stl is correct on my machine, it guarantees correctness on yours as well

later on it might also be expanded to allow eg. nix build github:gaspode-t-wonderdog/moxon-frame-generator#v3b -- --mhz 433 --dia 1 to get the stl to your machine without cloning the repo or installing openscad

it was very helpful for me, as I wanted to change this antenna to my liking, but this single commit can ofc be reverted

also don't see the benefit of the other changes mixed in here

  • ik the online moxon calculator gives a,b,c,d,e, but only looking at the code I think gap_lengthetc are much more helpful

  • and the change of the comments such that the customizer panel understands the categories is basically a no brainer

hope this helps in understanding

a PR should address a single concern

thats true and I can split this PR into 2 in case the maintainer deems one of the changes as more useful than you do ;P

@gretel

gretel commented Feb 20, 2026

Copy link
Copy Markdown

rn its only so that every developer here has the same openscad installed when entering the folder (direnv), no need to manage that, and if the stl is correct on my machine, it guarantees correctness on yours as well

openscad is a mathematical way to define geometry. rules of math do not change per computer. with all due respect but i think you are making this benefit up for the sake of nix.

later on it might also be expanded to allow eg. nix build github:gaspode-t-wonderdog/moxon-frame-generator#v3b -- --mhz 433 --dia 1 to get the stl to your machine without cloning the repo or installing openscad

this has been well possible by using the openscad cli. i think you are missing the requirement of nix itself here.

thats true and I can split this PR into 2 in case the maintainer deems one of the changes as more useful than you do ;P

i'm just asking questions cause i don't get the benefit of the proposed changes. that's all, have a nice day.

@HannesGitH

Copy link
Copy Markdown
Author

that might be true :D

The version of openscad I had installed on my mac didnt support the manifold backend, which is way faster, and as another config file (which I myself use anyway) doesnt do much harm I thought I could let others benefit from that as well :D

But again, if the maintainer opposes, I'm happy to only include the changes they like :)

@gretel

gretel commented Feb 20, 2026

Copy link
Copy Markdown

homebrew provides what suffices for my personal use:

https://formulae.brew.sh/cask/openscad@snapshot

But again, if the maintainer opposes, I'm happy to only include the changes they like :)

i think you are refering to the author. there is no maintainer, and it's not required for a project of this dimension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants