Skip to content

Feature/pokemon select#24

Merged
gblcintra merged 5 commits intomainfrom
feature/pokemon_select
Mar 27, 2026
Merged

Feature/pokemon select#24
gblcintra merged 5 commits intomainfrom
feature/pokemon_select

Conversation

@gblcintra
Copy link
Copy Markdown
Owner

No description provided.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 27, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2fd2c2e.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 11f428761e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +15 to +17
useEffect(() => {
if (!pokemon?.location_area_encounters) return

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reset encounter state before fetching a new Pokémon

When pokemon changes, the effect starts a new fetch but never clears locations or locationsError first. This means switching Pokémon can temporarily show the previous Pokémon’s encounter chips, and after any failed request the error banner can persist for subsequent successful selections (because locationsError is never set back to false). Resetting both pieces of state at the start of the effect avoids stale/incorrect UI data.

Useful? React with 👍 / 👎.

@gblcintra gblcintra merged commit 51d88d7 into main Mar 27, 2026
3 checks passed
@gblcintra gblcintra deleted the feature/pokemon_select branch March 27, 2026 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant