Refactor to support duplicate tokens #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The tests work! They fail on the genlm backend import Token class since it's not updated yet! Once that is merged on the backend, both will pass. |
samuki
reviewed
Jan 8, 2026
Member
samuki
left a comment
samuki
left a comment
There was a problem hiding this comment.
Could we change the target backend in pyproject.toml to check that all the tests are passing? Otherwise, it looks good, we just need to benchmark the speed.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supporting duplicate tokens (using the Token class in genlm-backend on the branch: genlm/genlm-backend#57). Also supporting multiple extends when multiple EOT's are found.