Add support for Trilogy MySQL adapter#163
Open
chriskozlowski wants to merge 1 commit intogeokit:masterfrom
Open
Add support for Trilogy MySQL adapter#163chriskozlowski wants to merge 1 commit intogeokit:masterfrom
chriskozlowski wants to merge 1 commit intogeokit:masterfrom
Conversation
Add trilogy adapter Revert "Add trilogy adapter" This reverts commit 767b56e.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| def geokit_finder_adapter | ||
| @geokit_finder_adapter ||= begin | ||
| unless Adapters.const_defined?(connection.adapter_name.camelcase) | ||
| unless Adapters.const_defined?(connection.adapter_name.camelcase, false) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [109/80]
| class Trilogy < MySQL | ||
| end | ||
| end | ||
| end No newline at end of file |
There was a problem hiding this comment.
Layout/TrailingBlankLines: Final newline missing.
| @@ -0,0 +1,8 @@ | |||
| require 'geokit-rails/adapters/mysql' | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true.
|
Any chance to merge this fixing the linter issues? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works for our use but did not fully test. Had to add the false argument to const_defined? in class_methods.rb or else the geokit_finder_adapter method would not load the new adapter. Not sure if that was an issue for other adapters or just the new one.