Skip to content

Comments

Use filesystemStore bean instead of hardcoded class#8486

Open
wangf1122 wants to merge 1 commit intogeonetwork:mainfrom
wangf1122:main.filestore.fix
Open

Use filesystemStore bean instead of hardcoded class#8486
wangf1122 wants to merge 1 commit intogeonetwork:mainfrom
wangf1122:main.filestore.fix

Conversation

@wangf1122
Copy link
Contributor

The intention of this code change is to fix potential issue with harvesting file store. The current file store was hardcoded to FileSystemStore class instead of dynamic bean injection.

The similar fix was apply to this pull request which is already merged https://github.com/geonetwork/core-geonetwork/pull/8466/files

Store store = ApplicationContextHolder.get().getBean("filesystemStore", Store.class);

Checklist

  • I have read the contribution guidelines
  • Pull request provided for main branch, backports managed with label
  • Good housekeeping of code, cleaning up comments, tests, and documentation
  • Clean commit history broken into understandable chucks, avoiding big commits with hundreds of files, cautious of reformatting and whitespace changes
  • Clean commit messages, longer verbose messages are encouraged
  • API Changes are identified in commit messages
  • Testing provided for features or enhancements using automatic tests
  • User documentation provided for new features or enhancements in manual
  • Build documentation provided for development instructions in README.md files
  • Library management using pom.xml dependency management. Update build documentation with intended library use and library tutorials or documentation

@wangf1122 wangf1122 marked this pull request as ready for review November 6, 2024 01:32
@josegar74 josegar74 added this to the 4.4.7 milestone Nov 6, 2024
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2024

CLA assistant check
All committers have signed the CLA.

@josegar74 josegar74 modified the milestones: 4.4.7, 4.4.8 Apr 10, 2025
@josegar74 josegar74 modified the milestones: 4.4.8, 4.4.9 May 28, 2025
@jahow jahow modified the milestones: 4.4.9, 4.4.10 Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants