ArcGIS Server Mapservice probe added

[LuukS]

Now it is possible to probe ArcGIS Server MapServices

[justb4]

Thanks, but before merging this needs to be addressed/added:

• major: esrims.py is mostly identical to the existing esrifs.py. Apart from naming I see only two differences in the Probe execution: "OBJECTID"(MS) vs 'objectIdFieldName' (FS) and if layer['subLayerIds'] is None: (MS). For maintenance it is better to merge all common code into a common baseclass like ESRIDrilldown and specialize subclasses ESRIMSDrilldown and ESRIFSDrilldown. I am not familiar with ESRI MS (though I wrote the FS Probe) but would expect to get actual raster maps, test for image content etc? So for example rename esrifs.py to esri.py and have all code (Basclass and two subclasses) in a single file. For example at some point the Authentication may need to be improved.
• add tests: basically only need to add to tests/data/fixtures.json (look for ESRI:FS how that is done).
• add documentation in docs/plugins.rst (look for ESRI:FS )
• add ESRI:MS to check in GeoHealthCheck/models.py line 433
• add ESRI:MS to check in GeoHealthCheck/healthcheck.py line 246

Maybe some other places, best is to search for 'ESRI' or 'ESRI:FS' in source tree.

Thanks for patience!

[LuukS]

I have changed the code and created an new way to test Feature- or MapServices based on the complete url of a service. I added this change in my repository. Can you have a look at it if it is OK now?

[PedroVenancio]

Hi @LuukS

I'm seeing that you are assuming in esrims.py the ID field always as OBJECTID:
https://github.com/geopython/GeoHealthCheck/pull/454/files#diff-b4de69f543dade9bc51e38f054d90e0977b562a66a33569447d737cefe198c9aR159

This is not always the case and GeoHealthCheck.plugins.probe.esrims.ESRIMSDrilldown fails when OBJECTID field is not present in that layer.

Is it possible to check the layer fields, search for esriFieldTypeOID field type and get obj_id_field_name from there?

Thanks!

[justb4]

I quickly glanced through the changes, but am a bit confused: I see the resource type changed from ESRI:FS to ESRI.
This will affect existing installations. My idea (see above) is to keep ESRI:FS and add ESRI:MS. But that the implementation uses a common baseclass. But I still see the full file esrims.py. Nowhere do I see the class GeoHealthCheck.plugins.probe.esri.ESRIDrilldown while it is refered in config_main.yml.

[LuukS]

I am confused as well. I changed the code and pushed it to my GitHub account. But I don’t see the changes in my code and also not in my pushed repo. Something went wrong. I have to find out what that was.. You’re right. I changed the ESRI:FS and created a new ESRI type. This supports both Feature- and Mapservice. I can add the ESRI:FS again so people can still use that one. With the new version I created you can use either Feature- or MapServices.

…

Op 17 aug. 2023, om 15:46 heeft Just van den Broecke ***@***.***> het volgende geschreven: I quickly glanced through the changes, but am a bit confused: I see the resource type changed from ESRI:FS to ESRI. This will affect existing installations. My idea (see above) is to keep ESRI:FS and add ESRI:MS. But that the implementation uses a common baseclass. But I still see the full file esrims.py. Nowhere do I see the class GeoHealthCheck.plugins.probe.esri.ESRIDrilldown while it is refered in config_main.yml. — Reply to this email directly, view it on GitHub <#454 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAKBZ6DHQDNOUTGDSDRKEZDXVYODPANCNFSM6AAAAAA2N2DCDM>. You are receiving this because you were mentioned.

[justb4]

Any way you/we can progress this @LuukS ?

[LuukS]

Hi @LuukS

I'm seeing that you are assuming in esrims.py the ID field always as OBJECTID: https://github.com/geopython/GeoHealthCheck/pull/454/files#diff-b4de69f543dade9bc51e38f054d90e0977b562a66a33569447d737cefe198c9aR159

This is not always the case and GeoHealthCheck.plugins.probe.esrims.ESRIMSDrilldown fails when OBJECTID field is not present in that layer.

Is it possible to check the layer fields, search for esriFieldTypeOID field type and get obj_id_field_name from there?

Thanks!

I changed to code in the latest commit to do this.