Add a Helmchart for GeoHealthCheck

[stranljip]

This PR adds a Helm chart for GeoHealth check which allows an easy deployment on Kubernetes.

[stranljip]

Closes #483

[stranljip]

This PR does not yet provide a publication mechanism for the Helmchart - this is something which should be done after incorporating the Helmchart.

[stranljip]

Hi - are there any contributors in this project who can have a look at my PR or is this project unmaintained and I should continue the work solely on my fork?

[justb4]

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.

I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future.
My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s?
Ok @tomkralidis ?

[tomkralidis]

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.

I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

[tomkralidis]

Some minor questions, thanks for this contribution!

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

[stranljip]

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

The Helm chart does only apply to k8s. docker/helm and docker/kubernetes do not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:

• docker --> install/docker-compose
• charts --> install/kubernetes/charts or charts/geohealthcheck --> install/kubernetes/helmchart

[stranljip]

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your docs dir?

[tomkralidis]

Sorry @stranljip . This project is still maintained, for example I run several production sites, including geoqos.com, only the maintainers have little time. Also for most the project has enough maturity to guard day-to-day geospatial webservices.
I have some experience in K8s, but not with Helm Charts. But I see all changes are under the charts directory, not affecting existing functionality. And very useful. So we could also just broadly review and merge your PR and trust you have the proper knowledge to maintain in the future. My only comment would be: naming the dir charts could be confusing, as within GHC we also draw status charts. Is it an idea to name the dir k8s? Or does Helm apply and the files under charts apply to more than K8s? Ok @tomkralidis ?

I'd probably create docker/helm and docker/kubernetes accordingly.

The Helm chart does only apply to k8s. docker/helm and docker/kubernetes do not "sound" quite right but I don't want to mess up your directory structure but I would suggest to refactor it a little bit:

* `docker` --> `install/docker-compose`

* `charts` --> `install/kubernetes/charts` or `charts/geohealthcheck` --> `install/kubernetes/helmchart`

fine to create /charts as you with (while keeping /docker the same).

[tomkralidis]

I would also suggest adding a new page in the docs on this functionality, as well as a Makefile as a convenience.

I have to admit that I am completely unfamiliar with this framework. Is your suggestion to add a Makefile in the Helmchart directory and add one page about the Helmchart or should I add a page in your docs dir?

Yes, add a Makefile so anyone wanting to run Helm has some help. For docs, thinking more, move the content of charts/docs/installhelm.rst (of this PR) into docs/install.rst add a section to page docs/install.rst.