gn-out-of-core-georchestra#329
Conversation
Makefile
Outdated
|
|
||
| docker: | ||
| cd web | ||
| ../mvnw package docker:build -Pdocker -DdockerImageName=georchestra/geonetwork -DdockerImageTags=${BTAG},latest -DskipTests -ntp |
There was a problem hiding this comment.
docker:build not necessary anymore, as the build step from the docker maven plugin has been attached to the package phase, just activating the docker profile will make it:
https://github.com/georchestra/geonetwork/blob/georchestra-gn4.4.x/web/pom.xml#L1662-L1667
There was a problem hiding this comment.
maybe we could do the same with the debian profile, in order to have a harmonized approach accross the build.
f-necas
force-pushed
the
gn-out-of-core-georchestra
branch
from
5c6ca8a to
402c5d8
Compare
georchestra-integration/pom.xml
Outdated
| <properties> | ||
| <rootProjectDir>${basedir}/..</rootProjectDir> | ||
| <georchestra.version>25.0.1-SNAPSHOT</georchestra.version> | ||
| <georchestra.version>24.0.11</georchestra.version> |
There was a problem hiding this comment.
a bit concerned about that detail.. that means we cant use new features (in the commons jars etc) that would happen to be in the master branch ? in the past we've had branches per-georchestra-branch for that .. cf https://github.com/georchestra/geonetwork/branches & the georchestra-gn4.2.x-2xxx branches. that would also allow stable vs main/master. But i'm not sure that matters much, just thinking out loud what would happen if there were diverging stuff in the deps.
the PR's first comment could explain more what the general (laudable) goal of the PR is ;)
There was a problem hiding this comment.
It must just be seen as a dependency. When I'll merge it, I'll will bump it to the latest stable version compatible : 25.0.0. After that we will have a dependabot or renovate who will propose us to bump it :)
There was a problem hiding this comment.
sure, and i guess eventually branch this repo if some commits depend on something that isnt in the stable georchestra branch ?
|
on a general note i'm of course +1 with the PR ! :) |
f-necas
force-pushed
the
gn-out-of-core-georchestra
branch
from
65e8b2d to
41e8ba0
Compare
3 participants
Implements georchestra/improvement-proposals#14 for GeoNetwork
geOrchestra/geonetwork checklist
What does this PR do?