fix: delete user saved selections if user is gone#352
Merged
f-necas merged 1 commit intogeorchestra-gn4.4.xfrom Feb 18, 2026
Merged
fix: delete user saved selections if user is gone#352f-necas merged 1 commit intogeorchestra-gn4.4.xfrom
f-necas merged 1 commit intogeorchestra-gn4.4.xfrom
Conversation
Member
|
Nice catch. |
Collaborator
Author
|
I don't think so, user should be in sync with console and external_user table and it happens only on them. |
pmauduit
approved these changes
Feb 13, 2026
Member
pmauduit
left a comment
There was a problem hiding this comment.
I thought I had commented on this one: I am surprised it requires an explicit deleteAllByUser call, and would have expected that JPA was capable of removing linked objects in its own model.
Other than that, looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes, user synchronization was failing with the error:
It's because someone who doesn't exist anymore has used the "Favorite" functionnality of GN (often used with datahub)
So we now delete those selections before trying to delete user.