You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.
Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).
I don't see hacs.json in your forked repo, so not sure if my pull request is applicable. On the other hand, I see my fix in diff on master...wuwentao:midea_ac_lan:master. Not sure why the file is gone though. Maybe it was removed in some later commit and that doesn't show in that view.
Either way, thanks for picking this up. I've installed the integration manually by checking out my own fork on the device, but I don't have the time to maintain it (accept pull requests and such), so glad that you do :-).
Why you don't see hacs.json in diff:
as most of the PR in current repo try to fix this input error, and we have fixed it in https://github.com/wuwentao/midea_ac_lan
so you can directly access it and check the file, it should be exist and already have right value now
in additional, there is too many code changes by python-black and python-isort code format tool, also fixed python flake8 with old source code, you can check the detail in my repo about the changes.
now it should be more script checks rule in new fork.
you can continue use your fork if you don't need any new update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #464