Skip to content

Replace engine with hook in create_table_from_query_using_pandas #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
edulauer merged 1 commit into from
Dec 4, 2025
Merged

Replace engine with hook in create_table_from_query_using_pandas #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions fastetl/custom_functions/utils/create_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ def create_table_from_query_using_pandas(
database.
"""

_, source_eng = get_hook_and_engine_by_provider(source.conn_id)
source_hook, source_eng = get_hook_and_engine_by_provider(source.conn_id)
_, destination_eng = get_hook_and_engine_by_provider(destination.conn_id)
source_eng.echo = True

Expand All @@ -386,8 +386,7 @@ def create_table_from_query_using_pandas(
query = query_first_row(source)

# Use pandas to execute the SQL and assign to the df
with source_eng.connect() as conn:
df_metadata = pd.read_sql(query, conn)
df_metadata = source_hook.get_pandas_df(query)

# Drop rows (keep the columns only)
df_metadata = df_metadata.drop(df_metadata.index)
Expand Down