Skip to content

fix(product-list): show the real product type instead of labeling every unknown type Simple #3358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akzmoudud wants to merge 1 commit into
base: develop
Choose a base branch
from
+77 −40
Open

fix(product-list): show the real product type instead of labeling every unknown type Simple #3358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 77 additions & 40 deletions src/dashboard/products/ProductList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,17 @@ import { useToast } from '@getdokan/dokan-ui';
import { addAction, applyFilters, removeAction } from '@wordpress/hooks';
import { Fill } from '@wordpress/components';
import { useNavigate } from 'react-router-dom';
import { Boxes, Package, ExternalLink, LayoutGrid, Plus } from 'lucide-react';
import {
Boxes,
Package,
ExternalLink,
LayoutGrid,
Plus,
RefreshCw,
Repeat,
Hammer,
} from 'lucide-react';
import type { LucideIcon } from 'lucide-react';
import {
DataViews,
DokanBadge,
Expand Down Expand Up @@ -92,53 +102,80 @@ const getStatusLabel = ( status: string ) => {
) as string;
};

/**
* Product types the current vendor may use, as a `{ slug: label }` map.
*
* Localized from PHP through the `dokan_product_types` filter, so types that
* come from modules — subscriptions, auctions, … — carry their own translated
* label. Lite alone localizes a plain slug list, which yields an empty map.
*/
Comment on lines +105 to +111

@coderabbitai coderabbitai Bot Jul 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

Add the required @since tags to the new JSDoc blocks.

As per coding guidelines, new code documentation must use the literal placeholder @since DOKAN_SINCE.

Proposed fix 
 /**
  * Product types the current vendor may use, as a `{ slug: label }` map.
  *
  * Localized from PHP through the `dokan_product_types` filter, so types that
  * come from modules — subscriptions, auctions, … — carry their own translated
  * label. Lite alone localizes a plain slug list, which yields an empty map.
+ *
+ * `@since` DOKAN_SINCE
  */
 
 /**
  * Icon per product type.
  *
  * Types owned by a module are listed too: the products keep their type when the
  * module is deactivated, so this is the baseline that keeps such a row from
  * looking like a simple product.
+ *
+ * `@since` DOKAN_SINCE
  */

Also applies to: 125-133

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/dashboard/products/ProductList.tsx` around lines 105 - 111, Add the
required `@since DOKAN_SINCE` tag to each new JSDoc block in ProductList.tsx,
including the product-types documentation and the additional block around the
referenced second section. Preserve the existing descriptions and formatting.

Source: Coding guidelines

const getVendorProductTypes = (): Record< string, string > => {
const types = ( window as any ).dokan?.product_types;

return types && ! Array.isArray( types ) ? types : {};
};

const PRODUCT_TYPE_LABELS: Record< string, string > = {
simple: __( 'Simple', 'dokan-lite' ),
variable: __( 'Variable', 'dokan-lite' ),
grouped: __( 'Grouped', 'dokan-lite' ),
external: __( 'External/Affiliate', 'dokan-lite' ),
};

/**
* Icon per product type.
*
* Types owned by a module are listed too: the products keep their type when the
* module is deactivated, so this is the baseline that keeps such a row from
* looking like a simple product. A module that needs richer output (the auction
* one greys the icon for closed auctions) still overrides the whole cell
* through `dokan_product_list_table_fields`.
*/
const PRODUCT_TYPE_ICONS: Record< string, LucideIcon > = {
simple: Package,
variable: Boxes,
grouped: LayoutGrid,
external: ExternalLink,
subscription: RefreshCw,
'variable-subscription': Repeat,
// Matches the auction module's own icon, so toggling it doesn't change the
// glyph — only the extras the module layers on.
auction: Hammer,
};

const getProductTypeLabel = ( item: ProductItem ) => {
if ( item.type === 'grouped' ) {
return __( 'Grouped', 'dokan-lite' );
}
if ( item.type === 'external' ) {
return __( 'External/Affiliate', 'dokan-lite' );
}
if ( item.type === 'variable' ) {
return __( 'Variable', 'dokan-lite' );
}
return __( 'Simple', 'dokan-lite' );
// The REST payload is typed, not guaranteed: a row without a type must not
// take the whole listing down with it.
const type = item.type || 'simple';

const label =
PRODUCT_TYPE_LABELS[ type ] ??
getVendorProductTypes()[ type ] ??
// Unknown type: humanize the slug rather than mislabel it as Simple.
type.replace( /[-_]/g, ' ' ).replace( /^./, ( c ) => c.toUpperCase() );

/**
* Filter the human-readable label for a product type.
*
* @since DOKAN_SINCE
*
* @param {string} label Default label.
* @param {string} type Product type slug.
*/
return applyFilters( 'dokan_product_type_label', label, type ) as string;
};

const ProductTypeIcon = ( { item }: { item: ProductItem } ) => {
const cls = 'w-5 h-5 text-gray-500';
if ( item.type === 'variable' ) {
return <Boxes className={ cls } />;
}
if ( item.type === 'grouped' ) {
return <LayoutGrid className={ cls } />;
}
if ( item.type === 'external' ) {
return <ExternalLink className={ cls } />;
}
return <Package className={ cls } />;
const Icon = PRODUCT_TYPE_ICONS[ item.type ] ?? Package;

return <Icon className="w-5 h-5 text-gray-500" />;
};

// ── Product type options ──────────────────────────────────────────────────────

const PRODUCT_TYPE_OPTIONS = [
{
value: 'simple',
label: __( 'Simple', 'dokan-lite' ),
},
{
value: 'variable',
label: __( 'Variable', 'dokan-lite' ),
},
{
value: 'grouped',
label: __( 'Grouped', 'dokan-lite' ),
},
{
value: 'external',
label: __( 'External/Affiliate', 'dokan-lite' ),
},
];
const PRODUCT_TYPE_OPTIONS = Object.entries( PRODUCT_TYPE_LABELS ).map(
( [ value, label ] ) => ( { value, label } )
);

// ── Product listing localized data from PHP ───────────────────────────────────

Expand Down