feat(ui): Display invite links on the staff page#251
Open
mtiller wants to merge 1 commit intogetmeli:nextfrom
Open
feat(ui): Display invite links on the staff page#251mtiller wants to merge 1 commit intogetmeli:nextfrom
mtiller wants to merge 1 commit intogetmeli:nextfrom
Conversation
This adds the invitation URL to the server response for invitations and it then leverages that URL on the client. The hope here is to address issue getmeli#247 and ideally just make it easier to use Meli without having to have a working email server to send out invites. Design note: I very deliberately pass a URL back from the server instead of just the bare token. The reason is that if I pass back a bare token then the UI will have to formulate the URL which means duplicating that logic both client and server side which I have a visceral dislike for (very bad code smell, IMHO). This way, only the server needs to know how to construct the URLs and it can unilaterally change the scheme if it wants with _zero_ impact on the client. Hypermedia for the win.
gempain
approved these changes
Feb 7, 2022
Contributor
|
@mtiller thanks so much for the contribution ! Will release this tonight. I think we should update the docs as well to emphasize this. It seems that the lint stage of the pipeline isn't passing, could you take a look ? Running the command |
Contributor
|
@mtiller I tried to modify your branch to save you time but it seems I can't. Happy to release a new beta with all your PRs once this one is merged 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the invitation URL to the server response for invitations and
it then leverages that URL on the client. The hope here is to address
issue #247 and ideally just make it easier to use Meli without having
to have a working email server to send out invites.
Design note: I very deliberately pass a URL back from the server
instead of just the bare token. The reason is that if I pass back
a bare token then the UI will have to formulate the URL which
means duplicating that logic both client and server side which
I have a visceral dislike for (very bad code smell, IMHO). This
way, only the server needs to know how to construct the URLs
and it can unilaterally change the scheme if it wants with
zero impact on the client. Hypermedia for the win.