Feature: Delete entity list#1466
Feature: Delete entity list#1466sadiqkhoja wants to merge 6 commits intogetodk:features/delete-dataset-and-propertiesfrom
Conversation
sadiqkhoja
force-pushed
the
features/deleted-entity-list
branch
5 times, most recently
from
1961ad7 to
ef22693
Compare
sadiqkhoja
force-pushed
the
features/deleted-entity-list
branch
from
ef22693 to
667f844
Compare
ktuite
left a comment
ktuite
left a comment
There was a problem hiding this comment.
Looks good and I've been successfully using it locally as well.
Are there going to be tests for the trash-row and trash-table components? Are those waiting on something?
| </i18n-t> | ||
| <br> | ||
| <span>{{ $t('dependentForms.description[1]') }}</span> | ||
| <a href="#">{{ $t('dependentForms.description[2]') }}</a> |
There was a problem hiding this comment.
"Learn more here" link to be filled in later. I imagine this'll go to some documentation? Or will we fill in some text here that says "update the forms to not write to or use entity lists as attachments, or delete the forms."?
There was a problem hiding this comment.
created getodk/central#1657 to track it.
| }); | ||
| }); | ||
|
|
||
| describe('dependent forms', () => { |
There was a problem hiding this comment.
These tests about dependent forms make sense for settings.spec.js but i think the other tests should go in a delete.spec.js file.
src/components/dataset/trash-row.vue
Outdated
| // TODO: API might be different for the deleted dataset (SK) | ||
| return apiPaths.entities(this.dataset.projectId, this.dataset.id, '.csv'); |
There was a problem hiding this comment.
We decided on /projects/:projectId/trash/datasets/:datasetId/entities.csv, but this means that existing request paths like apiPaths.entities don't fit the pattern.
There was a problem hiding this comment.
ah, I had this in a separate branch 🤦♂️
sadiqkhoja
force-pushed
the
features/deleted-entity-list
branch
2 times, most recently
from
53c71ae to
7ef10c6
Compare
sadiqkhoja
force-pushed
the
features/deleted-entity-list
branch
from
7ef10c6 to
95f8b46
Compare
|
2 participants
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes