Skip to content

Comments

Reimplement entity list in Compose#7107

Draft
seadowg wants to merge 8 commits intogetodk:masterfrom
seadowg:entity-material
Draft

Reimplement entity list in Compose#7107
seadowg wants to merge 8 commits intogetodk:masterfrom
seadowg:entity-material

Conversation

@seadowg
Copy link
Member

@seadowg seadowg commented Feb 19, 2026

This is something I did as part of #7096 that we didn't end up needing - it still felt worth having though.

Why is this the best possible solution? Were any other approaches considered?

Nothing to discuss really! I've just converted components to Compose.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

The entity browser and anywhere we show an error pill (selection maps and form lists) are the only things affected.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@seadowg
Copy link
Member Author

seadowg commented Feb 20, 2026

The connected tests currently fail because adding a ComposeView (or any clickable View) to a View used in a CursorAdapter causes the onItemClick listener to stop working. I'm parking this for the moment to work on higher priority stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant