Conversation
|
|
|
||
| <style scoped lang="scss"> | ||
| .table-layout { | ||
| width: max-content; |
There was a problem hiding this comment.
With this specified the "List group" section in the "All question types" form was forced too wide to fit within the form. I couldn't see any regression from removing it so I assume it's simply no longer required...
There was a problem hiding this comment.
I couldn't find what changed, so the UI started breaking after the upgrade. Do you know?
The only difference I see is that this branch has horizontal scrolling on mobile, which the preview doesn't have:
Branch:
Preview:
This list group is very tricky to fit. For now, we just make it look good on mobile (not perfect) as we get a better solution design for that. From the start, it doesn't split words; it just breaks on spaces (see the preview site). It's preferred to avoid horizontal scrolling in the form.
latin-panda
left a comment
latin-panda
left a comment
There was a problem hiding this comment.
I haven't tested in Central yet to see if any styles are overlapping incorrectly. I did check the datepicker, which PrimeVue had regressions before, and the number input that #469 seems fixed, and #467 is improved.
Here are some things I found when testing WF in the demo page in Chrome:
1.. The input type number is wider now (you can check with Aly if that's still okay)
In branch (233px)
Before (193px)
2.. Labels not wrapping
In branch:
Before:
Please consider sending it to QA Team to test other forms, test on iPhone, and verify the previous bugs :)
|
|
||
| <style scoped lang="scss"> | ||
| .table-layout { | ||
| width: max-content; |
There was a problem hiding this comment.
I couldn't find what changed, so the UI started breaking after the upgrade. Do you know?
The only difference I see is that this branch has horizontal scrolling on mobile, which the preview doesn't have:
Branch:
Preview:
This list group is very tricky to fit. For now, we just make it look good on mobile (not perfect) as we get a better solution design for that. From the start, it doesn't split words; it just breaks on spaces (see the preview site). It's preferred to avoid horizontal scrolling in the form.
|
@latin-panda Yeah, I think I was a bit optimistic. It's so time consuming to test primevue because CSS is a terrible API, so even a minor bump can cause a major issue. How about we go back to locking down primevue until we need to upgrade for a feature or bug fix that warrants the testing time required to make it safe? |
I'm divided. It's potentially fixing 2 nice bugs: #469 and #467, but yes, we'll need to fix new issues in this upgrade. |
|
@latin-panda I've merged the vitest PR into this one, and reverted primevue and raised an issue to tackle it separately: #675 |
2 participants
Updating primevue changes the behaviour of: #467
It's now a completely different bug but I think it's slightly better - let me know if you disagree!
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Do we need any specific form for testing your changes? If so, please attach one.
What's changed