fix: HTML issues with bootstrap2-dark theme#785
Open
gianluca-mascolo wants to merge 1 commit intogetpelican:masterfrom
Open
fix: HTML issues with bootstrap2-dark theme#785gianluca-mascolo wants to merge 1 commit intogetpelican:masterfrom
gianluca-mascolo wants to merge 1 commit intogetpelican:masterfrom
Conversation
Author
|
@farseerfc looking back at github history looks like you are the original author of this theme (Thank you I like it!). Maybe you can help by commenting the PR 🙏 |
Contributor
|
I was the original author for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried using the bootstrap2-dark theme, but when I generated the output with Pelican it failed the CI tests run with python html5validator and htmltest.
Since I’m not an HTML expert at all, I asked Claude AI to help me fix the theme templates. I personally reviewed the changes, and they make sense to me. Overall, this patch removes undefined variables, duplicate tags, and other minor issues of that kind.
A detailed explanation of the applied patch, along with the reason why each fix was necessary, can be found in my GitHub repository here.
A live version of this patched theme is available on my personal website here.