Skip to content

Preserve string column values that look like datetimes #7646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmosafi wants to merge 2 commits into
base: master
Choose a base branch
from
+9 −2
Open

Preserve string column values that look like datetimes #7646

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af7cedf
Preserve string column values that look like datetimes
nmosafi Feb 25, 2026
561aae9
Merge branch 'master' into fix-nanosecond-timestamp-display
nmosafi Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions client/app/services/query-result.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,13 @@ class QueryResult {

const columnTypes = {};

// Build a lookup of backend-provided column types so we can
// avoid converting values the backend has already typed correctly.
const backendColumnTypes = {};
each(this.query_result.data.columns, (column) => {
backendColumnTypes[column.name] = column.type;
});

// TODO: we should stop manipulating incoming data, and switch to relaying
// on the column type set by the backend. This logic is prone to errors,
// and better be removed. Kept for now, for backward compatability.
Expand All @@ -151,10 +158,10 @@ class QueryResult {
let newType = null;
if (isNumber(v)) {
newType = "float";
} else if (isDateTime(v)) {
} else if (backendColumnTypes[k] !== "string" && isDateTime(v)) {
row[k] = moment.utc(v);
newType = "datetime";
} else if (isString(v) && v.match(/^\d{4}-\d{2}-\d{2}$/)) {
} else if (backendColumnTypes[k] !== "string" && isString(v) && v.match(/^\d{4}-\d{2}-\d{2}$/)) {
row[k] = moment.utc(v);
newType = "date";
} else if (typeof v === "object" && v !== null) {
Expand Down
Loading