Skip to content

Block query results API when public URLs are disabled #7679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shunki-fujita wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −0
Open

Block query results API when public URLs are disabled #7679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions redash/handlers/query_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,9 @@ def post(self, query_id):
any cached result, or executes if not available. Set to zero to
always execute.
"""
if self.current_user.is_api_user() and self.current_org.get_setting("disable_public_urls"):
abort(400, message="Public URLs are disabled.")

params = request.get_json(force=True, silent=True) or {}
parameter_values = params.get("parameters", {})

Expand Down Expand Up @@ -301,6 +304,9 @@ def get(self, query_id=None, query_result_id=None, filetype="json"):
:<json number runtime: Length of execution time in seconds
:<json string retrieved_at: Query retrieval date/time, in ISO format
"""
if self.current_user.is_api_user() and self.current_org.get_setting("disable_public_urls"):
abort(400, message="Public URLs are disabled.")

# TODO:
# This method handles two cases: retrieving result by id & retrieving result by query id.
# They need to be split, as they have different logic (for example, retrieving by query id
Expand Down
Loading