feat(sentry-apps): Add is_disabled field to SentryApp model#114263
Draft
Christinarlong wants to merge 1 commit intomasterfrom
Draft
feat(sentry-apps): Add is_disabled field to SentryApp model#114263Christinarlong wants to merge 1 commit intomasterfrom
Christinarlong wants to merge 1 commit intomasterfrom
Conversation
Add a boolean `is_disabled` column to support disabling Sentry Apps at the platform level. This is the foundation for admin controls that will allow staff to disable misbehaving apps (INC-1550 follow-up). Also removes the dead `_disable()` model method and its unused `disable_sentryapp` RPC, which were a workaround that only cleared webhook events rather than truly disabling the app. ISWF-1234
github-actions
Bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a boolean field to sentry apps to represent if the app is disabled or not. Preferred this over making another status since with statuses you have to somehow store/remember the previous.
Also removes some dead code related to disabling which idt we'll need.
Refs ISWF-1234