perf(snapshots): Buffer image swap to eliminate flash during single-view navigation#114271
Open
NicoHinderling wants to merge 2 commits into04-28-ref_snapshots_final_ui_tweaksfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f2a32ed. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Switching between images in single-view mode had a noticeable delay — the old image would disappear immediately, leaving a blank flash while the browser fetched and decoded the new one.
Two fixes:
loading="eager"+decoding="async"— The coreImagecomponent defaults toloading="lazy", which is counterproductive for single-view images since they're always in the viewport. Switching to eager removes the lazy-load heuristic delay.decoding="async"keeps the decode non-blocking.useBufferedImageUrlhook — Instead of swapping the<img> srcimmediately (which clears the old image), this hook pre-decodes the new image vianew Image().decode()in the background and only swaps the URL once it's paint-ready. The old image stays on screen the entire time, so there's no blank gap.List-view images are unaffected — they correctly use
loading="lazy"viasnapshotDiffBodies.tsx.