Skip to content

Fixed bug where highcharts-container has wrong width.#136

Open
joejordanbrown wants to merge 4 commits intogevgeny:masterfrom
joejordanbrown:patch-1
Open

Fixed bug where highcharts-container has wrong width.#136
joejordanbrown wants to merge 4 commits intogevgeny:masterfrom
joejordanbrown:patch-1

Conversation

@joejordanbrown
Copy link
Copy Markdown

When no width is set and the component element chart is not display: block; the .highcharts-container can have the wrong width calculated.

When no width is set and the component element `chart` is not `display: block;` the .highcharts-container can have the wrong width calculated.
@tibysko
Copy link
Copy Markdown

tibysko commented Feb 19, 2017

Thanks for this! I just added 'display: block' to the chart tag 👍

@gevgeny
Copy link
Copy Markdown
Owner

gevgeny commented Feb 19, 2017

Should we really fix this ? If you need your chart to be block you can do it in the client code

@joejordanbrown
Copy link
Copy Markdown
Author

It should be display: block; on the host element because almost all components that contain inner element data are display block by default in HTML for example <div>, <p>, <section>, <footer>, <article>, <aside>. So this is expected with Angular components too. It's been discussed on the Angular GitHub page but it's a breaking change, so that's my guess why it hasn't been changed as the default for all Angular components.

@lebnic
Copy link
Copy Markdown

lebnic commented Mar 8, 2017

This bug's been affecting me aswell; fix is good, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants