Skip to content

Release spirv 0.4.0 and rspirv 0.13.0#274

Merged
MarijnS95 merged 1 commit intomasterfrom
release
Mar 13, 2026
Merged

Release spirv 0.4.0 and rspirv 0.13.0#274
MarijnS95 merged 1 commit intomasterfrom
release

Conversation

@MarijnS95
Copy link
Collaborator

@MarijnS95 MarijnS95 commented Mar 13, 2026

Closes #259

Also switch to trusted publishing.

@MarijnS95 MarijnS95 requested a review from cwfitzgerald March 13, 2026 15:17
Publish:
if: github.repository_owner == 'gfx-rs'
runs-on: ubuntu-latest
# environment: release
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you do.

Github completely broke the outside collaborator permission dialog and I had to use the damn github api through the CLI to make you admin....

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! I didn't set up any specific requirements for the release environment yet, let's see how it fares first.

Comment on lines -20 to -22
run: cargo publish --manifest-path spirv/Cargo.toml --token ${{ secrets.cratesio_token }}
- name: Publish rspirv
run: cargo publish --manifest-path rspirv/Cargo.toml --token ${{ secrets.cratesio_token }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this publish succeeds after merging + pushing the tags, I'll drop the secret.

Copy link
Member

@cwfitzgerald cwfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it! Please feel free to make whatever environments or whatever to get things set up.

Also switch to trusted publishing.
@MarijnS95 MarijnS95 merged commit 70541d5 into master Mar 13, 2026
18 checks passed
@MarijnS95 MarijnS95 deleted the release branch March 13, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for a New Release

2 participants