Open
Conversation
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
from
09165f0 to
866acc3
Compare
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
from
866acc3 to
ce5f133
Compare
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
3 times, most recently
from
cbe3175 to
6285067
Compare
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
2 times, most recently
from
2369bd9 to
dcbda19
Compare
inner-daemons
suggested changes
Mar 10, 2026
Collaborator
inner-daemons
left a comment
inner-daemons
left a comment
There was a problem hiding this comment.
Some nits, plus questions. Very exciting stuff overall, glad to see progress!
| crate::ShaderStage::Miss => { | ||
| self.require_any("ray tracing pipelines", &[spirv::Capability::RayTracingKHR])?; | ||
| spirv::ExecutionModel::MissKHR | ||
| } |
Collaborator
There was a problem hiding this comment.
Is there a tracking issue for CallableKHR?
Contributor
Author
There was a problem hiding this comment.
Not yet, at some point I need to split up the main ray tracing issue.
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
5 times, most recently
from
4d6e37e to
a8c005f
Compare
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
3 times, most recently
from
41578a2 to
ce2fa89
Compare
Vecvec
force-pushed
the
spv-ray-tracing-pipelines
branch
from
ce2fa89 to
d6bc32c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Part of #6760
Description
This adds support for ray tracing pipelines to spirv-out, as well as extracting things useful to the both ray queries and ray tracing pipelines to
ray.rs. The validation this includes is just what is already in ray queries (now extracted to a separate function), there is no recursion validation yet.Testing
Snapshot tests
Squash or Rebase?
Squash
Checklist
cargo fmt.cargo clippy --tests.cargo xtask testto run tests.CHANGELOG.mdentry.