Enforce formatting on *.{md,js,html,yml}, non-blocking edition#9297
Merged
ErichDonGubler merged 4 commits intogfx-rs:trunkfrom Mar 25, 2026
Merged
Conversation
7 tasks
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
087f989 to
cf77df8
Compare
ErichDonGubler
changed the title
*.{md,js,html,yml}, non-blocking edition
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
cf77df8 to
8a3abb9
Compare
ErichDonGubler
commented
Mar 24, 2026
| @@ -1,4 +1,5 @@ | |||
| **/*.frag | |||
| **/*.vert | |||
| deno_webgpu/**/*.js | |||
Member
Author
There was a problem hiding this comment.
thought: Hey @crowlKats, I think it might be interesting for us to enforce this formatting for deno_webgpu, but I didn't want to conflict with any style enforcement that deno might have. Would it be a problem if we, say, implemented 9300599 and squashed it into this?
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
2 times, most recently
from
3399657 to
ab29c2a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
3 times, most recently
from
fcd0334 to
131a6e9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
131a6e9 to
4d30352
Compare
Member
|
In the meeting, we have resolved to have this be a required check. |
cwfitzgerald
requested changes
Mar 25, 2026
Member
cwfitzgerald
left a comment
cwfitzgerald
left a comment
There was a problem hiding this comment.
After our discussion, could you merge the CI job into the other format job?
cwfitzgerald
approved these changes
Mar 25, 2026
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
3 times, most recently
from
0bcbfe3 to
225b1e1
Compare
This actually may enforce the format of other files than these, but we don't use them, so far as I'm aware. If we want to opt out of other formats later, that's what `.prettierignore` is for.
ErichDonGubler
force-pushed
the
fmt-md-js-html-yml
branch
from
225b1e1 to
62bad15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Spurred by discussion at #9269 (CC @andyleiserson, @cwfitzgerald): #9269 (review)
Description
Add a check to CI that checks formatting of these files. If they get reformatted, fail.
Note that this is not intended to become a required check. This is just hoping to preempt formatting divergences faster for attentive maintainers, rather than discovering them when other work is being done. 😭
Recommended review experience is commit-by-commit.
Testing
CI!
Checklist
Add/modify entry(ies) inNot necessary.CHANGELOG.md.UX for failures is awful; need a get a diff. of whatThis has been fixed; see https://github.com/gfx-rs/wgpu/actions/runs/23517163180/job/68452203786?pr=9297 for an example of a diff. printed out by a failed job.prettierwants to change, to get parity with other tools. Suggested action: follow-up work with issues