Implements #8875: Using binding_array should require an enable extension#9298
Open
39ali wants to merge 7 commits intogfx-rs:trunkfrom
Open
Implements #8875: Using binding_array should require an enable extension#929839ali wants to merge 7 commits intogfx-rs:trunkfrom
39ali wants to merge 7 commits intogfx-rs:trunkfrom
Conversation
Member
|
I believe the failing CI are simply requiring that you update the snapshot output files. Be sure you're running |
Contributor
Author
|
@jimblandy not sure what's wrong with the changelog |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connections
Fixes #8875
Description
this requires
wgpu_binding_arrayto be enabled in the shader to usebinding_arrayTesting
i added some tests to test this feature
Checklist
cargo fmt.taplo format.cargo clippy --tests. If applicable, add:--target wasm32-unknown-unknowncargo xtask testto run tests.CHANGELOG.mdentry.