hexagon: use DIRID 13 in libggml-htp.inf for modern InfVerif#22306
Open
mengshengwu wants to merge 1 commit intoggml-org:masterfrom
Open
hexagon: use DIRID 13 in libggml-htp.inf for modern InfVerif#22306mengshengwu wants to merge 1 commit intoggml-org:masterfrom
mengshengwu wants to merge 1 commit intoggml-org:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
libggml-htp.infis used by the WoS build to produce and signlibggml-htp.catfor the HTP skel.sofiles (seeggml/src/ggml-hexagon/CMakeLists.txt). When the signed package was submitted to the Microsoft signing team,InfVerifrejected it because:DIRID 6historically referred to a legacy/root directory and is no longer a validDestinationDirsvalue under the current InfVerif rules (Windows 11 build >= 10.0.27871).DIRID 13, i.e.%DriverStore%\FileRepository\<inf>_<hash>\.This is also consistent with how Qualcomm's own
qcadsprpcdriver is deployed on WoS —htp-drv.cppalready resolveslibcdsprpc.dllout of\SystemRoot\System32\DriverStore\FileRepository\qcadsprpc....Verification
InfVerifaccepts the package and the MS signing pipeline succeeds (DIRID 6 was previously rejected).libggml-htp.catwithout issue.libggml-htp-vXX.sofrom the DriverStore location at runtime, so the move does not break the skel lookup path.Requirements
NO