This repository was archived by the owner on May 10, 2026. It is now read-only.
fix: apply naval academy runtime catch-up on login - #233
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5eb8032fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
internal/orm/naval_academy_runtime.goto load/create/save per-commander naval academy runtime state in config storage.internal/answer/playerops/last_login.goto run naval academy catch-up before login state is sent.internal/answer/playerops/resources_info.goto source canteen/merchant levels and renovation timers from runtime state.internal/answer/playerops/naval_academy_runtime.gowith template parsing, level clamping, renovation completion handling, and accrual computation that pauses during renovation.internal/answer/config_handlers_test.gowith coverage for runtime-backed timers, level normalization, and login catch-up accrual.