macOS: fix intrinsicContentSize race in windowDidLoad#11322
Merged
mitchellh merged 2 commits intoghostty-org:mainfrom Mar 10, 2026
Merged
macOS: fix intrinsicContentSize race in windowDidLoad#11322mitchellh merged 2 commits intoghostty-org:mainfrom
mitchellh merged 2 commits intoghostty-org:mainfrom
Conversation
…g#11256) Tests that validate intrinsicContentSize returns a correct value when TerminalController.windowDidLoad() reads it. Currently fail, proving the race condition where @focusedvalue hasn't propagated lastFocusedSurface before the 40ms timer fires. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
) Add initialContentSize fallback on TerminalViewContainer so intrinsicContentSize returns the correct value immediately, without waiting for @focusedvalue to propagate. This removes the need for the DispatchQueue.main.asyncAfter 40ms delay. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #11256 and #11271.
Tested manually with various combination of
window-width/heightandmacos-titlebar-style.Screen.Recording.2026-03-10.at.15.58.01.mp4
AI Disclosure
All the commits are generated by Claude, but orchestrated and manually tested by myself.