chore: cleanup values and templates after v11 upgrade#498
Merged
QuentinBisson merged 11 commits intomainfrom Apr 9, 2026
Merged
chore: cleanup values and templates after v11 upgrade#498QuentinBisson merged 11 commits intomainfrom
QuentinBisson merged 11 commits intomainfrom
Conversation
- Delete custom ScaledObject wrapper templates (backend, gateway, read, write):
upstream v11 now ships native so.yaml for all four components; keeping both
would render duplicate ScaledObjects in the cluster
- Remove kedaAutoscaling value blocks (gateway, backend, read, write): consumed
only by the deleted wrapper templates
- Remove selfMonitoring block: dead code, removed from upstream prior to v11
- Remove loki.loki.{pod,container}SecurityContext overrides: identical to
upstream v11 defaults; upstream additionally sets fsGroupChangePolicy which
our override was suppressing
- Remove loki.gateway.{pod,container}SecurityContext overrides: identical to
upstream v11 defaults
Kept intentional differences:
- loki.sidecar.securityContext: adds seccompProfile absent in upstream
- gateway.metrics.enabled: false: access-log-exporter image not in gsoci mirror
- gateway.route.*: GiantSwarm-specific HTTPRoute wrapper (no upstream equivalent)
- Remove stale schema entries: kedaAutoscaling (gateway, read), selfMonitoring, and security context overrides now matching upstream - Remove selfMonitoring from example values files - Rename sample_configs/ to examples/ - Update README links accordinglyMSGEOF git commit -F /tmp/commit_msg.txt
- chunksCache.enabled, resultsCache.enabled: upstream defaults to true - monitoring.dashboards.enabled, monitoring.rules.enabled: upstream defaults to false - monitoring.alerts.enabled: dead code, upstream v11 controls alerts via monitoring.rules.alerting, no template reads this value - serviceAccount.create/imagePullSecrets/annotations/labels/automountServiceAccountToken: all upstream defaults; keep only name: loki which differs - lokiCanary.updateStrategy: identical to upstream default
Strip all values that are identical to the wrapper or upstream defaults, leaving only intentional overrides in each example file.
- Remove loki.lokiCanary.image.registry — global.image.registry already takes priority in the loki.image helper (coalesce precedence) - Remove loki.serviceAccount.name: loki — loki.fullname resolves to "loki" when Release.Name contains "loki", which is always the case for GiantSwarm managed apps
QuentinBisson
commented
Apr 9, 2026
QuentinBisson
commented
Apr 9, 2026
hervenicol
approved these changes
Apr 9, 2026
Contributor
hervenicol
left a comment
hervenicol
left a comment
There was a problem hiding this comment.
Works for me if it works for you.
I see you're still pushing lots of changes, so I assume you're in the process of testing it.
QuentinBisson
commented
Apr 9, 2026
Inside {{- with $route.hostnames }}, . is scoped to the list, so passing
. as the tpl context caused "wrong type for value; expected chartutil.Values"
when hostnames was non-empty. Use $ (the root context) instead.
Removing this caused the SA name to become release-name-loki when the Helm release name differs from "loki". Pinning it ensures a stable name regardless of release name, which is required for IRSA/workload identity annotations referencing the SA by name.
Contributor
Author
|
I'm mostly diffing and fixing small nitpicks :D |
Contributor
Author
|
Running on graveler |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
so.yamlfor all four components; keeping both would render duplicate ScaledObjectskedaAutoscalingvalue blocks that were only consumed by the deleted templatesselfMonitoringdead code (removed from upstream before v11)loki/gatewaypod/container security context overrides — identical to upstream v11 defaults (upstream additionally gainsfsGroupChangePolicy: OnRootMismatch)chunksCache.enabled,resultsCache.enabled,monitoring.dashboards.enabled,monitoring.rules.enabled,serviceAccount.*(exceptname),lokiCanary.updateStrategymonitoring.alerts.enabled— dead code, upstream v11 controls alerts viamonitoring.rules.alertingsample_configs/→examples/Template diff (before / after)
The rendered
helm templateoutput is identical before and after — all removed values were either matching upstream defaults or dead code with no templates consuming them.