Fix --crawl-replace-URLs when used with --output-directory#190
Open
brasswood wants to merge 1 commit intogildas-lormeau:masterfrom
Open
Fix --crawl-replace-URLs when used with --output-directory#190brasswood wants to merge 1 commit intogildas-lormeau:masterfrom
--crawl-replace-URLs when used with --output-directory#190brasswood wants to merge 1 commit intogildas-lormeau:masterfrom
Conversation
- Initialize/update options.outputDirectory to a good string in single-file-launcher.js - Use it to open files when replacing URLs Note that prepending outputDirectory to pageData.filename or task.filename won't work. Downloaded files will have their references to URLs replaced by references to some task.filename. This means task.filename needs to be a path relative to the parent task's filename. The parent task's file is already saved in the outputDirectory, meaning we should not prepend outputDirectory. The only time we prepend outputDirectory is when a path will be interpreted relative to the program's current working directory, such when opening a file for reading. Possibly fixes gildas-lormeau#131.
brasswood
changed the title
brasswood
changed the title
--crawl-replace-URLs when used with --output-directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note that prepending outputDirectory to pageData.filename or task.filename won't work. Downloaded files will have their references to URLs replaced by references to some task.filename. This means task.filename needs to be a path relative to the parent task's filename. The parent task's file is already saved in the outputDirectory, meaning we should not prepend outputDirectory.
The only time we prepend outputDirectory is when a path will be interpreted relative to the program's current working directory, such when opening a file for reading.
Possibly fixes #131.