[codex] Ensure but-graph keeps exact target segments#13222
Draft
Byron wants to merge 1 commit intogitbutlerapp:masterfrom
Draft
[codex] Ensure but-graph keeps exact target segments#13222Byron wants to merge 1 commit intogitbutlerapp:masterfrom
Byron wants to merge 1 commit intogitbutlerapp:masterfrom
Conversation
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
but-graphalways creates an exact target segment for configured workspace target refs when the graph would otherwise only contain the local tracking segmentRoot Cause
but-graphcould end up with only a local tracking segment likemain <> origin/mainand no exactrefs/remotes/origin/mainsegment. The workspace projection expects the configured target ref to exist as its own segment, so target resolution could fail or become shape-dependent after post-processing.Impact
This normalizes the graph shape for configured workspace targets so downstream workspace logic can rely on the exact target segment existing when possible.
Validation
cargo fmt --check --allcargo test -p but-graphNotes