Floating point decimal support has been removed from CodeQL

[jketema]

Description

please enter the description of your change here

Change request type

• Release or process automation (GitHub workflows, internal scripts)
• Internal documentation
• External documentation
• Query files (.ql, .qll, .qls or unit tests)
• External scripts (analysis report or other code shipped as part of a release)

Rules with added or modified queries

• No rules added
• Queries have been added for the following rules:
  • rule number here
• Queries have been modified for the following rules:
  • rule number here

Release change checklist

A change note (development_handbook.md#change-notes) is required for any pull request which modifies:

• The structure or layout of the release artifacts.
• The evaluation performance (memory, execution time) of an existing query.
• The results of an existing query in any circumstance.

If you are only adding new rule queries, a change note is not required.

Author: Is a change note required?

• Yes
• No

🚨🚨🚨
Reviewer: Confirm that format of shared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.

• Confirmed

Reviewer: Confirm that either a change note is not required or the change note is required and has been added.

• Confirmed

Query development review checklist

For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:

Author

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

Reviewer

• Have all the relevant rule package description files been checked in?
• Have you verified that the metadata properties of each new query is set appropriately?
• Do all the unit tests contain both "COMPLIANT" and "NON_COMPLIANT" cases?
• Are the alert messages properly formatted and consistent with the style guide?
• Have you run the queries on OpenPilot and verified that the performance and results are acceptable?
  As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
• Does the query have an appropriate level of in-query comments/documentation?
• Have you considered/identified possible edge cases?
• Does the query not reinvent features in the standard library?
• Can the query be simplified further (not golfed!)

[Copilot]

Pull request overview

This pull request removes support for Decimal float types (Decimal32Type, Decimal64Type, Decimal128Type) from the CRealTypeExtensionExtension class in response to these types being removed from CodeQL. The class now only detects Float128Type.

Changes:

• Simplified the CRealTypeExtensionExtension constructor to only check for Float128Type
• Removed checks for Decimal32Type, Decimal64Type, and Decimal128Type

Comments suppressed due to low confidence (3)

c/common/src/codingstandards/c/Extensions.qll:127

• The error message mentions "Decimal floats" but the class now only detects Float128Type (not decimal float types). The message should be updated to accurately reflect that it's checking for 128-bit floating point types (like __float128), not decimal float types.

This issue also appears in the following locations of the same file:

• line 121
• line 122

  override string getMessage() {
    result = "Decimal floats are a compiler extension and are not portable to other compilers."
  }

c/common/src/codingstandards/c/Extensions.qll:121

• The reference comment still points to gcc/Decimal-Float.html documentation, but the class no longer checks for decimal float types (Decimal32Type, Decimal64Type, Decimal128Type). Since the class now only detects Float128Type, the reference to Decimal-Float.html should be removed and only the __int128.html reference (which covers __float128 as well) should remain, or a more appropriate reference for Float128 types should be added.

// Reference: https://gcc.gnu.org/onlinedocs/gcc/Decimal-Float.html#Decimal-Float

c/common/src/codingstandards/c/Extensions.qll:122

• The class name "CRealTypeExtensionExtension" has a duplicated "Extension" suffix and is now misleading since it only detects Float128Type (a specific 128-bit floating point type) rather than all "real type extensions". Consider renaming to something like "CFloat128Extension" to be more accurate and consistent with similar classes like "CIntegerTypeExtension".

class CRealTypeExtensionExtension extends CCompilerExtension, DeclarationEntry {

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.