feat: add describe_decode_error and describe_decode_errors function to decode module#909
Open
bcpeinhardt wants to merge 5 commits intogleam-lang:mainfrom
Open
Conversation
Member
|
Hello! Any additions needs to be discussed and a design agreed on prior to implementation. Please open an issue that details the motivations, use cases, and alternatives that have been considered 🙏 |
Author
|
@lpil done 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There currently isn't a user facing describe_error style function for the decode module. I really like the describe_error pattern that's popped up in Gleam, especially for using the snag package. However,
decode.runreturns a list of decode errors. In this PR, I've added both adescribe_decode_erroranddescribe_decode_errorsfunction. This makes using the result of a decode.run with an ad-hoc error type more ergonomic.Ideally, packages like gleam_json could build on this to provide their own describe_error functions. Let me know what you think!