Make it easily change remote and/or local media count limits

[sinoru]

This will introduce easily configurable env to change media limits by:

GLITCH_MAX_LOCAL_MEDIA_ATTACHMENTS
GLITCH_MAX_REMOTE_MEDIA_ATTACHMENTS

This PR is some part of mastodon#27833.
This will fix #1975.

[mkody]

Why make another file and not use the .env?
Sure we can use the <%= ENV %> but why make hoops and not keep things consistent with the rest of the project?
For other developers and instance admins, this adds unneeded complexity which would increase with time as things might get added to either .env or the .yml, and keeping track of that is a forthcoming nightmare.
And anticipating the "why not move everything to mastodon.yml": please don't put more burden again on instance admins and the available tools that already work great, environment variables are important for many deployments too.

[sinoru]

Why make another file and not use the .env? Sure we can use the <%= ENV %> but why make hoops and not keep things consistent with the rest of the project? For other developers and instance admins, this adds unneeded complexity which would increase with time as things might get added to either .env or the .yml, and keeping track of that is a forthcoming nightmare. And anticipating the "why not move everything to mastodon.yml": please don't put more burden again on instance admins and the available tools that already work great, environment variables are important for many deployments too.

@mkody I approached it for better code management. Those value can be accessed by config.x.mastodon on any rails code. Furthermore, I think it's too much to open all values to env that don't need to changed easily, which are close to constant values. I understand this might seem like that. Or maybe I can't find a single file where the constants are gathered. If not, I think it's an approach worth considering.

I think about to create a single constant file to contains all constant across the codes:

If this is too much, or If a lot of people disagree, I can change it to accept the opinion.

[mkody]

If anything, I don't think this should be done partially and being slipped in with another change... and if not done partially, you need to consider it being either backwards compatible or make it a breaking change with plenty of warnings to instance owners.

Skipping my opinion, this PR is missing a way to handle missing keys, like default values as a fallback. You need to consider that deployments may not see file changes and do merges, like Docker-based deployments, if they have to mount the file to change this (which is... terrible, ENV variables would be better here - or this should be set in the admin UI).

I would also argue that for glitch-only features, they should be in a glitch.yml file, and either the values get merged into config.x.mastodon or we have a clearly distinct config.x.glitch.

[sinoru]

If anything, I don't think this should be done partially and being slipped in with another change... and if not done partially, you need to consider it being either backwards compatible or make it a breaking change with plenty of warnings to instance owners.

Actually, If I supplies env, than it doesn't introduce backwards breakable changes.

Skipping my opinion, this PR is missing a way to handle missing keys, like default values as a fallback. You need to consider that deployments may not see file changes and do merges, like Docker-based deployments, if they have to mount the file to change this (which is... terrible, ENV variables would be better here - or this should be set in the admin UI).

I agrees with that. I need to adds some env. But even that, It will be great for easily accessible constant will be great for development.

I would also argue that for glitch-only features, they should be in a glitch.yml file, and either the values get merged into config.x.mastodon or we have a clearly distinct config.x.glitch.

Right. I missed this point. I agreed.

[github-actions]

This pull request has merge conflicts that must be resolved before it can be merged.

[TheEssem]

It looks like a good chunk of this was superseded in mastodon#30433, however that PR still uses a hardcoded value and didn't add any config options.

[CustardFlan]

This missing feature is the reason why i abandoned my vanilla Mastodon instance and migrated to Sharkey
Now i'm using GTS, but i wanted to go back using glitch-soc because the gts federation issues...
Please, add that feature! 🫰