-
Notifications
You must be signed in to change notification settings - Fork 447
feat: add p/gnoland/antisquat anti-squatting library #5126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
politas180
wants to merge
8
commits into
gnolang:master
Choose a base branch
from
politas180:feat/antisquat-design-impl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Core implementation with: - AVL tree-backed storage (O(log n) all operations) - Rate limiting with per-address pruning - Protected names with dynamic add/remove - Length-based pricing (correct ugnot values) - Name lifecycle (register, renew, resolve, expire)
Tests cover: - Name validation (format, length, edge cases) - Registration (success, duplicates, normalization) - Reserved names (add, remove, check, normalization) - Rate limiting (per-address, window-based) - Pricing (all tiers, correct ugnot values) - Name resolution and record retrieval - Per-address name listing - Expiry and grace period logic
Comprehensive design for p/gnoland/antisquat addressing all review feedback from PR gnolang#5074. Includes three-tier namespace architecture, Phase 1 implementation details, Phase 2 auction/identity roadmap, security analysis, and deployment plan. Ref: gnolang#2727
Collaborator
🛠 PR Checks Summary🔴 Pending initial approval by a review team member, or review from tech-staff Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📖 documentation
Improvements or additions to documentation
🧾 package/realm
Tag used for new Realms or Packages.
review/triage-pending
PRs opened by external contributors that are waiting for the 1st review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
p/gnoland/antisquat, a pluggable anti-squatting library for gno.land namespace management.Closes #2727
What this PR includes
1. Working
p/gnoland/antisquatpackage (7 files, ~500 lines + tests):errors.gno— Error constantstypes.gno— NameRecord, ReservedCategory, rateLimitEntryconfig.gno— Config, PricingTier, DefaultConfig()validation.gno— Name validation and normalizationantisquat.gno— Main engine with 4 AVL trees, all O(log n) operationsantisquat_test.gno— 20+ test functions2. Design document (
docs/design/antisquat-design.md)Key design decisions (addressing @notJoon's review on #5074)
Pricing tiers
Related: #2727, #2827, #4937