Add libdispatch based NSOperationQueue implementation#602
Open
HendrikHuebner wants to merge 8 commits intognustep:masterfrom
Open
Add libdispatch based NSOperationQueue implementation#602HendrikHuebner wants to merge 8 commits intognustep:masterfrom
HendrikHuebner wants to merge 8 commits intognustep:masterfrom
Conversation
Contributor
Author
|
Hm I can't reproduce the build failure locally, will try again later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new implementation for
NSOperationQueue, which uses libdispatch instead of manually spawning threads.The internal queue implementation is split into two classes:
GSDispatchOperationQueueandGSThreadOperationQueue. If libdispatch is available, the dispatch implementation is chosen, otherwise we fall back to the old implementation. The logic for the thread implementation remains mostly unchanged, except for the structural change of moving most of the implementation to another class. I also fixed a bug here: If thread creation throws, we did not decrement the thread count afterwards.Additionally, this PR adds the
underlyingQueueproperty setter and getter, which is only enabled for libdispatch based implementations. See Apple docs for reference.