Skip to content

correct typo and rename fileType to fieldType in AlterColumn#7748

Open
cragone wants to merge 1 commit intogo-gorm:masterfrom
cragone:fix/alter-column-typos
Open

correct typo and rename fileType to fieldType in AlterColumn#7748
cragone wants to merge 1 commit intogo-gorm:masterfrom
cragone:fix/alter-column-typos

Conversation

@cragone
Copy link
Copy Markdown

@cragone cragone commented Apr 7, 2026

Renames the misnamed 'fileType' to 'fieldType', as well as fixed the typo for column' to column's.

  • Do only one thing
  • Non breaking API changes
  • Tested

What did this pull request do?

  • Changed a typo in the AlterColumn method description, was missing an s for the column's ownership of its type.
  • Changed variable name fileType to fieldType as it refers to a column or a field not a file type.

User Case Description

Any reader of AlterColumn would be confused by a variable called fileType in a database migration context. fieldType matches the intent.

@propel-code-bot
Copy link
Copy Markdown
Contributor

Fix AlterColumn comment typo and rename local variable to fieldType

This PR makes a small clarity-focused change in migrator/migrator.go within Migrator.AlterColumn(). It corrects a grammar typo in the method comment (column' to column's) and renames the local variable fileType to fieldType to better reflect that the value represents a schema field/column type.

No functional behavior, SQL generation, or API surface is changed. The executed statement and arguments remain equivalent, with only identifier naming and inline documentation improved.

Key Changes

• Updated AlterColumn comment text in migrator/migrator.go to fix possessive typo
• Renamed local variable fileType to fieldType in Migrator.AlterColumn()
• Updated m.DB.Exec(...) argument from fileType to fieldType

Affected Areas

migrator/migrator.go
Migrator.AlterColumn() implementation
• Inline method documentation/comments

This summary was automatically generated by @propel-code-bot

Copy link
Copy Markdown
Contributor

@propel-code-bot propel-code-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review found no issues; the PR is a safe, non-functional clarity improvement.

Status: No Issues Found | Risk: Low

Review Details

📁 1 files reviewed | 💬 0 comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant