fix Content-Type header not being set for error responses#260
Merged
Conversation
Replace WriteHeader + RenderJSON pattern with EncodeJSON to ensure Content-Type: application/json header is set before WriteHeader is called. This fixes go-pkgz/rest#38 where responses had text/plain content-type.
Pull Request Test Coverage Report for Build 20277117952Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WriteHeader+RenderJSONpattern withEncodeJSONto ensureContent-Type: application/jsonheader is set beforeWriteHeaderis calledtext/plaincontent-type instead ofapplication/jsonAffected endpoints:
/auth/logout(when no providers defined) → 400 Bad Request/auth/user(when not authenticated) → 401 Unauthorized