[WIP] Update to CLDR v38. Fixes #32.#33
Open
bojanz wants to merge 1 commit intogo-playground:masterfrom
Open
Conversation
Contributor
Author
|
For the record, this bug has been introduced by unicode-org/cldr@4116d54 and the related documentation https://docs.google.com/document/d/1Wx9Drhpl9p2ZqVZMGQ7KUF4pUfPtuJupv8oQ_Gf6sEE/edit#heading=h.enp59k5s3h0h from the ticket https://unicode-org.atlassian.net/browse/CLDR-12010 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is going to be tough to review. Perhaps it would be easier to do the update in jumps (e.g. v32 -> v34 -> v36 -> v38).
With the newline fix in parseDateTimeFormat() I was able to get the generation process to complete.
However, multiple tests are failing. The most notable ones are for fr*, and for a reason:
e is undefined, which means there's another bug in generate_resources.go, most likely in parseCardinalPluralRuleFunc.